From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbdFRA4X (ORCPT ); Sat, 17 Jun 2017 20:56:23 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35981 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752908AbdFRA4U (ORCPT ); Sat, 17 Jun 2017 20:56:20 -0400 From: SeongJae Park To: shuah@kernel.org Cc: bamvor.zhangjian@linaro.org, shorne@gmail.com, davem@davemloft.net, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH 2/3] selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGS Date: Sun, 18 Jun 2017 09:56:03 +0900 Message-Id: <20170618005604.17639-3-sj38.park@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170618005604.17639-1-sj38.park@gmail.com> References: <20170618005604.17639-1-sj38.park@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Build of aperf fails as below: ``` gcc -Wall -D_GNU_SOURCE -lm aperf.c -o /tools/testing/selftests/intel_pstate/aperf /tmp/ccKf3GF6.o: In function `main': aperf.c:(.text+0x278): undefined reference to `sqrt' collect2: error: ld returned 1 exit status ``` The faulure occurs because -lm was defined as LDFLAGS and implicit rule of make places LDFLAGS before source file. This commit fixes the problem by using LDLIBS instead of LDFLAGS. Signed-off-by: SeongJae Park --- tools/testing/selftests/intel_pstate/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/intel_pstate/Makefile b/tools/testing/selftests/intel_pstate/Makefile index 19678e90efb2..849a90ffe8dd 100644 --- a/tools/testing/selftests/intel_pstate/Makefile +++ b/tools/testing/selftests/intel_pstate/Makefile @@ -1,5 +1,5 @@ CFLAGS := $(CFLAGS) -Wall -D_GNU_SOURCE -LDFLAGS := $(LDFLAGS) -lm +LDLIBS := $(LDLIBS) -lm TEST_GEN_FILES := msr aperf -- 2.13.0