public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, He Kuang <hekuang@huawei.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Namhyung Kim <namhyung@kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] perf unwind: Limit warnings when asked for not supported unwind
Date: Mon, 19 Jun 2017 00:53:08 +0200	[thread overview]
Message-ID: <20170618225308.GC13111@krava> (raw)
In-Reply-To: <20170616162504.GJ3645@kernel.org>

On Fri, Jun 16, 2017 at 01:25:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 16, 2017 at 02:12:53PM +0200, Jiri Olsa escreveu:
> > Ingo reported following warning flooding the report out:
> > 
> >   unwind: target platform=x86 is not supported
> > 
> > We trigger this warning when the dwarf unwinder is asked to
> > process architecture which wasn't compiled in, like when you
> > get 32bit application samples on your 64bit server and you
> > don't have the 32bit remote unwind support compiled in.
> > 
> > This patch limits the warning to single message for arch,
> > and adds bits info. Above message is changed to:
> > 
> >   unwind: target platform=x86 32bit is not supported
> 
> Can we have a more informative message telling the user what is
> necessary to have this feature supported?
> 
> The way you phrased it looks like it is not supported at all, while what
> I read in the discussion is that one needs to have specific versions of
> support libraries installed to have this working, right?

exactly, I'll dig out from changelogs needed libunwind version
and change the changelog in v2

jirka

  reply	other threads:[~2017-06-18 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 12:12 [PATCH] perf unwind: Limit warnings when asked for not supported unwind Jiri Olsa
2017-06-16 16:25 ` Arnaldo Carvalho de Melo
2017-06-18 22:53   ` Jiri Olsa [this message]
     [not found]     ` <CA+JHD91HyFiNkRpJU+y1ppQO6t8KS3QQKEacNw_bu6s9PFH11w@mail.gmail.com>
2017-06-19 21:28       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618225308.GC13111@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox