From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbdFSHZj (ORCPT ); Mon, 19 Jun 2017 03:25:39 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:53174 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdFSHZh (ORCPT ); Mon, 19 Jun 2017 03:25:37 -0400 Date: Mon, 19 Jun 2017 08:25:34 +0100 From: Al Viro To: Deepa Dinamani Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, john.stultz@linaro.org, nicolas.pitre@linaro.org, arnd@arndb.de, y2038@lists.linaro.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Message-ID: <20170619072534.GB10672@ZenIV.linux.org.uk> References: <20170619064515.922-1-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170619064515.922-1-deepa.kernel@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 18, 2017 at 11:45:07PM -0700, Deepa Dinamani wrote: > The series aims at isolating data conversions of time_t based structures: > struct timespec and struct itimerspec at user space boundaries. > This helps to later change the underlying types to handle y2038 changes > to these. > > The series is an update to Arnd Bergmann's previous series: > http://sourceware.org/ml/libc-alpha/2015-05/msg00070.html > > The series particularly aims at changing kernel clock and timer interfaces. > > The changes include > a. Add data conversion apis for native and compat modes. > b. Refactor nanosleep and clock_nanosleep logic: > 1. Move nanosleep and its compat version to a new file nanosleep.c. > Alternatively, these can be moved into hrtimer.c. > 2. Refactor common functions for nanosleep: same functions > are used for posix timers and posix stubs. > 3. Change the posix clock callbacks to take advantage of these > common functions. > b. Move compat syscalls to the same files as the regular syscalls. > c. Use data conversion apis in the regular and compat syscall paths. > d. Remove set_fs()/get_fs() calls in the compat syscall path and > use the same logic as in the regular syscall path. Check the stuff already in tip/timers/core; at the very least it overlaps considerably with your series. And your variant is a lot more convoluted - there's no need to have a separate compat restart, etc.