public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jim Davis <jim.epost@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion
Date: Mon, 19 Jun 2017 07:30:38 -0300	[thread overview]
Message-ID: <20170619073038.666a0eba@vento.lan> (raw)
In-Reply-To: <20170618234630.19964-3-corbet@lwn.net>

Em Sun, 18 Jun 2017 17:46:27 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:

> Commit 85c21e5c3ee7 (docs-rst: better adjust margins and font size) added a
> \usepackage{geometry} that conflicts with another inclusion deep within the
> dependencies somewhere, causing the the PDF build to fail with a
> "conflicting parameters" error.  Just remove it for now until we can figure
> out a better way.
> 
> Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> ---
>  Documentation/conf.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index 93827bc1620f..3d4e89330044 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -271,8 +271,6 @@ latex_elements = {
>  
>  # Additional stuff for the LaTeX preamble.
>      'preamble': '''
> -	% Adjust margins
> -	\\usepackage[margin=0.5in, top=1in, bottom=1in]{geometry}
>          \\usepackage{ifthen}

This patch has a bad side effect: with it, the tables with this tag:
	.. tabularcolumns::

become too big, violating the right margin. If Sphinx 1.5.x or
1.6.x replaced geometry package with something else, then I
guess we'll need to add some hack at conf.py for it to adjust
it based on the Sphinx version.

Btw, in order to build latex output here with Sphinx 1.6.x,
I had to install this package:

	texlive-fncychap.noarch

Perhaps the change is somehow related to it.

Btw, the current documentation at:
	http://www.sphinx-doc.org/en/stable/latex.html

added a new option for version 1.5.3 and upper, to setup the
geometry, using 'sphinxsetup'. As described there:

	'sphinxsetup': 'hmargin={2in,1.5in}, vmargin={1.5in,2in}, marginpar=1in',

I'll play with it and see if I can use it on such versions.

Thanks,
Mauro

  reply	other threads:[~2017-06-19 10:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 23:46 [PATCH 0/5] Make PDF builds work again Jonathan Corbet
2017-06-18 23:46 ` [PATCH 1/5] Docs: Include the Latex "ifthen" package Jonathan Corbet
2017-06-18 23:46 ` [PATCH 2/5] Docs: Remove redundant geometry package inclusion Jonathan Corbet
2017-06-19 10:30   ` Mauro Carvalho Chehab [this message]
2017-06-19 10:49     ` Mauro Carvalho Chehab
2017-06-23 19:39       ` Jonathan Corbet
2017-06-23 21:26         ` Mauro Carvalho Chehab
2017-06-18 23:46 ` [PATCH 3/5] Docs: fix table problems in ras.rst Jonathan Corbet
2017-06-18 23:46 ` [PATCH 4/5] Docs: Use kernel-figure in vidioc-g-selection.rst Jonathan Corbet
2017-06-18 23:46 ` [PATCH 5/5] DRM: Fix an incorrectly formatted table Jonathan Corbet
2017-06-18 23:48 ` [PATCH 0/5] Make PDF builds work again Jonathan Corbet
2017-06-19  1:18 ` Mauro Carvalho Chehab
2017-06-19 14:43   ` Mauro Carvalho Chehab
2017-07-03  8:25 ` Daniel Vetter
2017-07-03 12:44   ` Jonathan Corbet
2017-07-05 21:22     ` Jim Davis
2017-07-06  8:28       ` Markus Heiser
2017-07-06  9:54       ` Mauro Carvalho Chehab
2017-07-05 20:03   ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619073038.666a0eba@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=corbet@lwn.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=jim.epost@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox