From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbdFSIrr (ORCPT ); Mon, 19 Jun 2017 04:47:47 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35288 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdFSIrq (ORCPT ); Mon, 19 Jun 2017 04:47:46 -0400 Date: Mon, 19 Jun 2017 10:47:43 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kai-Heng Feng Cc: andy@infradead.org, Matthew Garrett , dvhart@infradead.org, platform-driver-x86@vger.kernel.org, LKML Subject: Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface Message-ID: <20170619084743.GB32387@pali> References: <20170619073629.14239-1-kai.heng.feng@canonical.com> <20170619075742.GA32387@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 19 June 2017 16:39:14 Kai-Heng Feng wrote: > The same rule should also apply to kbd_info.levels, right? IIRC no. levels = 1 means you can set two levels (0 and 1). Look into code. -- Pali Rohár pali.rohar@gmail.com