public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
	Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
	Valery Cherepennikov <valery.cherepennikov@intel.com>,
	David Carrillo-Cisneros <davidcc@google.com>,
	Stephane Eranian <eranian@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi
Date: Mon, 19 Jun 2017 13:46:40 +0100	[thread overview]
Message-ID: <20170619124639.GA3661@leverpostej> (raw)
In-Reply-To: <22a2dafb-de05-199b-54ed-0c3b24349826@linux.intel.com>

On Fri, Jun 16, 2017 at 05:22:29PM +0300, Alexey Budankov wrote:
> On 16.06.2017 17:08, Alexey Budankov wrote:
> >On 16.06.2017 12:09, Mark Rutland wrote:
> >>On Fri, Jun 16, 2017 at 01:10:10AM +0300, Alexey Budankov wrote:
> >>>On 15.06.2017 22:56, Mark Rutland wrote:
> >>>>On Thu, Jun 15, 2017 at 08:41:42PM +0300, Alexey Budankov wrote:
> >>>>>This series of patches continues v2 and addresses captured comments.
> >>
> >>>>>Specifically this patch replaces pinned_groups and flexible_groups
> >>>>>lists of perf_event_context by red-black cpu indexed trees avoiding
> >>>>>data structures duplication and introducing possibility to iterate
> >>>>>event groups for a specific CPU only.
> >>>>
> >>>>If you use --per-thread, I take it the overhead is significantly
> >>>>lowered?
> >>>
> >>>Please ask more.
> >>
> >>IIUC, you're seeing the slowdown when using perf record, correct?
> >
> >Correct. Specifically in per-process mode - without -a option.
> >
> >>
> >>There's a --per-thread option to ask perf record to not duplicate the
> >>event per-cpu.
> >>
> >>If you use that, what amount of slowdown do you see?
> 
> After applying all three patches:
> 
> - system-wide collection:
> 
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 303.795 MB perf.data (~13272985 samples) ]
> 2162.08user 176.24system 0:12.97elapsed 18021%CPU (0avgtext+0avgdata
> 1187208maxresident)k
> 0inputs+622624outputs (0major+1360285minor)pagefaults 0swaps
> 
> - per-process collection:
> 
> [ perf record: Woken up 5 times to write data ]
> [ perf record: Captured and wrote 1.079 MB perf.data (~47134 samples) ]
> 2102.39user 153.88system 0:12.78elapsed 17645%CPU (0avgtext+0avgdata
> 1187156maxresident)k
> 0inputs+2272outputs (0major+1181660minor)pagefaults 0swaps
> 
> Elapsed times look similar. Data file sizes differ significantly.

Interesting. I wonder if that's because we're losing samples due to
hammering the rb, or if that's a side-effect of this patch.

Does perf report describe any lost chunks?

For comparison, can you give --per-thread a go prior to these patches
being applied?

Thanks,
Mark.

  reply	other threads:[~2017-06-19 12:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 17:41 [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Alexey Budankov
2017-06-15 19:56 ` Mark Rutland
2017-06-15 22:10   ` Alexey Budankov
2017-06-16  9:09     ` Mark Rutland
2017-06-16 14:08       ` Alexey Budankov
2017-06-16 14:22         ` Alexey Budankov
2017-06-19 12:46           ` Mark Rutland [this message]
2017-06-19 13:38             ` Mark Rutland
2017-06-19 14:09               ` Alexey Budankov
2017-06-19 14:59               ` Andi Kleen
2017-06-19 15:09                 ` Mark Rutland
2017-06-19 15:21                   ` Andi Kleen
2017-06-19 15:24                     ` Mark Rutland
2017-06-19 15:39                       ` Andi Kleen
2017-06-19 15:52                         ` Mark Rutland
2017-06-19 13:08     ` Alexey Budankov
2017-06-19 13:26       ` Mark Rutland
2017-06-19 13:37         ` Alexey Budankov
2017-06-19 15:00           ` Alexey Budankov
2017-06-19 15:24             ` Andi Kleen
2017-06-19 15:34               ` Alexey Budankov
2017-06-30 10:23                 ` Alexey Budankov
2017-06-30 10:21             ` Alexey Budankov
2017-06-19 15:14           ` Mark Rutland
2017-06-19 15:27             ` Alexey Budankov
2017-06-30 10:21           ` Alexey Budankov
2017-06-19 20:31   ` Alexey Budankov
2017-06-20 13:36     ` Mark Rutland
2017-06-20 15:22       ` Alexey Budankov
2017-06-20 16:37         ` Mark Rutland
2017-06-20 17:10           ` Alexey Budankov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619124639.GA3661@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Dmitry.Prohorov@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=valery.cherepennikov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox