From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751015AbdFSSYG (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 14:24:06 -0400
Received: from mail.kernel.org ([198.145.29.99]:44508 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750878AbdFSSYF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 14:24:05 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6231C239E2
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 19 Jun 2017 15:24:01 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        kernel-team@lge.com, Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/4] perf ftrace: Show error message when fails to set
 ftrace files
Message-ID: <20170619182401.GP3645@kernel.org>
References: <20170618142302.25390-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170618142302.25390-1-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sun, Jun 18, 2017 at 11:22:59PM +0900, Namhyung Kim escreveu:
> It'd be better for debugging to show an error message when it fails to
> setup ftrace for some reason.

Thanks a lot, tested the series, excellent ftrace subset to support in
'perf ftrace'! :-)

- Arnaldo
 
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-ftrace.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
> index 9e0b35cd0eea..966a94fa8200 100644
> --- a/tools/perf/builtin-ftrace.c
> +++ b/tools/perf/builtin-ftrace.c
> @@ -61,6 +61,7 @@ static int __write_tracing_file(const char *name, const char *val, bool append)
>  	int fd, ret = -1;
>  	ssize_t size = strlen(val);
>  	int flags = O_WRONLY;
> +	char errbuf[512];
>  
>  	file = get_tracing_file(name);
>  	if (!file) {
> @@ -75,14 +76,16 @@ static int __write_tracing_file(const char *name, const char *val, bool append)
>  
>  	fd = open(file, flags);
>  	if (fd < 0) {
> -		pr_debug("cannot open tracing file: %s\n", name);
> +		pr_debug("cannot open tracing file: %s: %s\n",
> +			 name, str_error_r(errno, errbuf, sizeof(errbuf)));
>  		goto out;
>  	}
>  
>  	if (write(fd, val, size) == size)
>  		ret = 0;
>  	else
> -		pr_debug("write '%s' to tracing/%s failed\n", val, name);
> +		pr_debug("write '%s' to tracing/%s failed: %s\n",
> +			 val, name, str_error_r(errno, errbuf, sizeof(errbuf)));
>  
>  	close(fd);
>  out:
> -- 
> 2.13.0