From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754498AbdFSSmP (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 14:42:15 -0400
Received: from mail.kernel.org ([198.145.29.99]:47236 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753931AbdFSSmM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 14:42:12 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D235F2397B
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 19 Jun 2017 15:42:09 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Kim Phillips <kim.phillips@arm.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused
 by misplaced __printf
Message-ID: <20170619184209.GB13640@kernel.org>
References: <20170616145907.baba73eda242efe194e072d0@arm.com>
 <CANLsYkyG3E9xiOyJz_5EA0B0oQGsSCy2oW7i1iY5YUxU1imKng@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANLsYkyG3E9xiOyJz_5EA0B0oQGsSCy2oW7i1iY5YUxU1imKng@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Jun 19, 2017 at 11:51:20AM -0600, Mathieu Poirier escreveu:
> On 16 June 2017 at 13:59, Kim Phillips <kim.phillips@arm.com> wrote:
> > -static int cs_device__print_file(const char *name, const char *fmt, ...) __printf(2, 3)
> > +static int __printf(2, 3) cs_device__print_file(const char *name, const char *fmt, ...)
> >  {
> >         va_list args;
> >         FILE *file;
> 
> I just tested Kim's solution on my side.
> 
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks for checking, since I haven't pushed this to Ingo I just squashed
Kim's fix into the buggy cset.

Now I'm trying to build it with lots of cross build containers to see if
there are any other problems before push this up to Ingo.

- Arnaldo