From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462AbdFSTNp (ORCPT ); Mon, 19 Jun 2017 15:13:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbdFSTNn (ORCPT ); Mon, 19 Jun 2017 15:13:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C3E239AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 19 Jun 2017 16:13:30 -0300 From: Arnaldo Carvalho de Melo To: Jin Yao Cc: Jiri Olsa , Peter Zijlstra , mingo@infradead.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate Message-ID: <20170619191330.GC13640@kernel.org> References: <1497840958-4759-1-git-send-email-yao.jin@linux.intel.com> <1497840958-4759-4-git-send-email-yao.jin@linux.intel.com> <20170619173529.GM3645@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170619173529.GM3645@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 19, 2017 at 02:35:29PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu: > > Marker always there, not just when we have the cursor on top of one of > those lines remains to be coded. > > But you state: > > ------------ > Macro fusion merges two instructions to a single micro-op. Intel core > platform performs this hardware optimization under limited > circumstances. > ------------ > > "Intel core", what about older arches, etc, don't you have to look at: > > # cpudesc : Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz > # cpuid : GenuineIntel,6,61,4 > > present in the perf.data header (or in the running system, for things > like 'perf top') to make sure that this is a machine where such "macro > fusion" takes place? Ok, I have the patches that need this discussion to get to a conclusion on a separate patch, tmp.perf/annotate, the first patch, the one that returns the 'struct arch' for the browser to use arch specific stuff is in perf/core and can go to Ingo now. - Arnaldo