From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbdFSVNC (ORCPT ); Mon, 19 Jun 2017 17:13:02 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:49992 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbdFSVNB (ORCPT ); Mon, 19 Jun 2017 17:13:01 -0400 Date: Mon, 19 Jun 2017 22:12:58 +0100 From: Al Viro To: Deepa Dinamani Cc: Thomas Gleixner , Linux Kernel Mailing List , John Stultz , Nicolas Pitre , Arnd Bergmann , y2038 Mailman List , Linux FS-devel Mailing List Subject: Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Message-ID: <20170619211258.GK10672@ZenIV.linux.org.uk> References: <20170619064515.922-1-deepa.kernel@gmail.com> <20170619072534.GB10672@ZenIV.linux.org.uk> <20170619194634.GI10672@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2017 at 01:52:05PM -0700, Deepa Dinamani wrote: > On Mon, Jun 19, 2017 at 12:46 PM, Al Viro wrote: > > On Mon, Jun 19, 2017 at 12:31:00PM -0700, Deepa Dinamani wrote: > > > >> 3. I was also aiming for user pointers to be not touched by timer > >> specific code as it can get messy if not handled properly with 2 > >> compat time_t versions. > > > > So have one helper that deals with all copyout and have it used by > > all of them. IMO all that code should treat userland representation > > as completely opaque. Just switch nanosleep_copyout() to take > > timespec64 instead of timespec (for kernel-side object) and that'll > > do it, wouldn't it? > > Yes, that would work. > If that is preferred, then I will just do that and rebase the patches. Please, do. Note that quite a few things in that series won't be needed anymore (e.g. compat syscalls are already moved to native ones, etc.). Might make sense to take it to #kernel - lower latency that way...