From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/3] drm/fb-cma-helper: expose more of fb cma guts
Date: Mon, 19 Jun 2017 22:41:06 +0200 [thread overview]
Message-ID: <20170619224106.24a9dafc@bbrezillon> (raw)
In-Reply-To: <1497858266-17844-3-git-send-email-peda@axentia.se>
Le Mon, 19 Jun 2017 09:44:25 +0200,
Peter Rosin <peda@axentia.se> a écrit :
> DRM drivers supporting clut may want a convenient way to only use
> non-default .gamma_set and .gamma_get ops in the drm_fb_helper_funcs
> in order to avoid the following
>
> /*
> * The driver really shouldn't advertise pseudo/directcolor
> * visuals if it can't deal with the palette.
> */
> if (WARN_ON(!fb_helper->funcs->gamma_set ||
> !fb_helper->funcs->gamma_get))
> return -EINVAL;
>
> warning in drm_fb_helper.c:setcolreg().
Did you read the FIXME in the struct doc [1]? Shouldn't we try to move
to this generic approach instead of exposing fb_cma internals? You
could probably mimic (or re-use) what's done in
drm_mode_gamma_set/get_ioctl() [2].
[1]http://elixir.free-electrons.com/linux/v4.12-rc6/source/include/drm/drm_fb_helper.h#L110
[2]http://elixir.free-electrons.com/linux/v4.12-rc6/source/drivers/gpu/drm/drm_color_mgmt.c#L214
next prev parent reply other threads:[~2017-06-19 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 7:44 [PATCH v3 0/3] drm: atmel-hlcdc: clut support Peter Rosin
2017-06-19 7:44 ` [PATCH v3 1/3] drm: atmel-hlcdc: add support for 8-bit color lookup table mode Peter Rosin
2017-06-19 7:44 ` [PATCH v3 2/3] drm/fb-cma-helper: expose more of fb cma guts Peter Rosin
2017-06-19 20:41 ` Boris Brezillon [this message]
2017-06-19 7:44 ` [PATCH v3 3/3] drm: atmel-hlcdc: add clut support for legacy fbdev Peter Rosin
2017-06-19 7:48 ` [PATCH v3 0/3] drm: atmel-hlcdc: clut support Boris Brezillon
2017-06-19 20:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619224106.24a9dafc@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox