linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: wsa@the-dreams.de, robh+dt@kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid
Date: Tue, 20 Jun 2017 13:18:35 +1200	[thread overview]
Message-ID: <20170620011837.14010-4-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170620011837.14010-1-chris.packham@alliedtelesis.co.nz>

Use gpio_is_valid() instead of gpio > -1.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/i2c/busses/i2c-pca-platform.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index 87ca2f02f607..3a9845bae9a4 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -197,7 +197,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	} else {
 		i2c->adap.timeout = HZ;
 		i2c->algo_data.i2c_clock = 59000;
-		i2c->gpio = -1;
+		i2c->gpio = -ENODEV;
 	}
 
 	i2c->algo_data.data = i2c;
@@ -220,8 +220,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 		break;
 	}
 
-	/* Use gpio_is_valid() when in mainline */
-	if (i2c->gpio > -1) {
+	if (gpio_is_valid(i2c->gpio)) {
 		ret = gpio_request(i2c->gpio, i2c->adap.name);
 		if (ret == 0) {
 			gpio_direction_output(i2c->gpio, 1);
@@ -255,7 +254,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	if (irq)
 		free_irq(irq, i2c);
 e_reqirq:
-	if (i2c->gpio > -1)
+	if (gpio_is_valid(i2c->gpio))
 		gpio_free(i2c->gpio);
 
 	iounmap(i2c->reg_base);
@@ -277,7 +276,7 @@ static int i2c_pca_pf_remove(struct platform_device *pdev)
 	if (i2c->irq)
 		free_irq(i2c->irq, i2c);
 
-	if (i2c->gpio > -1)
+	if (gpio_is_valid(i2c->gpio))
 		gpio_free(i2c->gpio);
 
 	iounmap(i2c->reg_base);
-- 
2.13.0

  parent reply	other threads:[~2017-06-20  1:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  1:18 [PATCH v2 0/5] i2c: pca-platform: updates Chris Packham
2017-06-20  1:18 ` [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
2017-06-22  8:22   ` Wolfram Sang
2017-06-22 21:20     ` Chris Packham
2017-06-23  8:17       ` Wolfram Sang
2017-06-23 21:41       ` Rob Herring
2017-06-20  1:18 ` [PATCH v2 2/5] i2c: pca-platform: add devicetree awareness Chris Packham
2017-06-20  1:18 ` Chris Packham [this message]
2017-06-20  1:18 ` [PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-20  1:18 ` [PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham
2017-06-26  0:44 ` [PATCH v3 0/5] i2c: pca-platform: updates Chris Packham
2017-06-26  0:44   ` [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
2017-06-26 14:06     ` Rob Herring
2017-06-27 19:53     ` Wolfram Sang
2017-06-26  0:44   ` [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham
2017-06-27 19:53     ` Wolfram Sang
2017-06-28  9:25     ` Andy Shevchenko
2017-06-28 21:25       ` Chris Packham
2017-06-28 22:18         ` Wolfram Sang
2017-06-26  0:44   ` [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:20     ` Andy Shevchenko
2017-06-28  9:42       ` Wolfram Sang
2017-06-28 21:15       ` Chris Packham
2017-06-26  0:44   ` [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:23     ` Andy Shevchenko
2017-06-28  9:38       ` Wolfram Sang
2017-06-28 10:54         ` Andy Shevchenko
2017-06-28 21:03           ` Chris Packham
2017-06-26  0:44   ` [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:28     ` Andy Shevchenko
2017-06-28  9:37       ` Wolfram Sang
2017-06-28 10:57         ` Andy Shevchenko
2017-06-28 12:01           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620011837.14010-4-chris.packham@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).