Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API

Luca Coelho
2017-04-10T13:20:32Z

On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote:
> The driver data API provides support for looking for firmware
> from a specific set of API ranges, so just use that. Since we
> free the firmware on the callback immediately after consuming it,
> this also takes avantage of that feature.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---

Looks find, with one nitpick.

> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 67 ++++++++++------------------
> 1 file changed, 23 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> index be466a074c1d..b6643aa5b344 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c

[...]

> @@ -1541,11 +1522,9 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans)
> }
> #endif
>
> - ret = iwl_request_firmware(drv, true);
> - if (ret) {
> - IWL_ERR(trans, "Couldn't request the fw\n");
> + ret = iwl_request_firmware(drv);
> + if (ret)
> goto err_fw;
> - }

Why remove the error message here?

--
Cheers,
Luca.