From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdFTNX1 (ORCPT ); Tue, 20 Jun 2017 09:23:27 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57803 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdFTNX0 (ORCPT ); Tue, 20 Jun 2017 09:23:26 -0400 Date: Tue, 20 Jun 2017 06:23:24 -0700 From: Christoph Hellwig To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, sza@esh.hu, arnd@arndb.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, alexandre.torgue@st.com, robin.murphy@arm.com, benjamin.gaignard@linaro.org, kbuild-all@01.org, Joerg Roedel , Christian Borntraeger Subject: Re: [PATCH v5 2/7] dma: Add simple dma_noop_mmap Message-ID: <20170620132324.GA11370@infradead.org> References: <1495621472-9323-1-git-send-email-vladimir.murzin@arm.com> <1495621472-9323-3-git-send-email-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495621472-9323-3-git-send-email-vladimir.murzin@arm.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 11:24:27AM +0100, Vladimir Murzin wrote: > This patch adds a simple implementation of mmap to dma_noop_ops. Currently we use dma_common_mmap as the generic fallback if a dma_ops instance doesn't implement a mmap method. Can you just fix up dma_common_mmap for your nommu case - it looks like yours is basically a subset. In fact I suspect yours should call dma_mmap_from_coherent as well, so the only different is the lack of pgprot_noncached call.