public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "'Arnaldo Carvalho de Melo'" <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "Jiri Olsa (jolsa@kernel.org)" <jolsa@kernel.org>,
	"'Jiri Olsa'" <jolsa@redhat.com>,
	"'Peter Zijlstra'" <peterz@infradead.org>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'Ingo Molnar'" <mingo@kernel.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'Stephane Eranian'" <eranian@google.com>,
	"'elliott@hpe.com'" <elliott@hpe.com>,
	"'Andi Kleen'" <andi@firstfloor.org>
Subject: Re: [PATCH V2 0/2] measure SMI cost (user)
Date: Tue, 20 Jun 2017 17:29:02 -0300	[thread overview]
Message-ID: <20170620202902.GI13640@kernel.org> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775370F863@SHSMSX103.ccr.corp.intel.com>

Em Tue, Jun 20, 2017 at 01:43:56PM +0000, Liang, Kan escreveu:
> Hi Arnaldo and Jirka,
> 
> Ping.
>> Any comments for the patch?

I thought there was a kernel part still outstanding, now I see it was
already merged, will try it and provide comments.

- Arnaldo
 
> Thanks,
> Kan 
> 
> > Subject: RE: [PATCH V2 0/2] measure SMI cost (user)
> > 
> > Hi Jirka,
> > 
> > Have you got a chance to try the code?
> > Are you OK with the patch?
> > 
> > Thanks,
> > Kan
> > 
> > >
> > > Em Fri, Jun 02, 2017 at 03:45:11PM +0000, Liang, Kan escreveu:
> > > > > > On Mon, May 29, 2017 at 02:52:39PM +0200, Peter Zijlstra wrote:
> > > > > > > On Mon, May 29, 2017 at 02:46:37PM +0200, Jiri Olsa wrote:
> > > > > > > > for some reason I can't get single SMI count generated, is
> > > > > > > > there a setup/bench that would provoke that?
> > >
> > > > > > > Not having SMIs is a good thing ;-) Not sure we can tickle
> > > > > > > them in a reliable way.
> > >
> > > > > > yea I saw some counts last time, now just zero so I was
> > > > > > wondering if it's working
> > >
> > > > > We have internal test case which can generate SMI, but I cannot
> > > > > publish the test case. Sorry about that.
> > >
> > > > APM_CNT (0xB2) could be used to trigger SMI#.
> > >
> > > Here if I run the following 'perf stat' command and press the mute
> > > button (the one sharing F1 in a thinkpad t450s it triggers SMIs,
> > > toggle it in quick sucession and it generates more, etc:
> > >
> > > [root@jouet ~]# perf stat -I 1000 -e msr/smi/
> > > #           time             counts unit events
> > >      1.000103173                  0      msr/smi/
> > >      2.000278816                  4      msr/smi/
> > >      3.000472630                  4      msr/smi/
> > >      4.000743916                  0      msr/smi/
> > >      5.001369358                  4      msr/smi/
> > >      6.001668033                  0      msr/smi/
> > >      7.001852603                  4      msr/smi/
> > >      8.002108269                 12      msr/smi/
> > >      9.002367312                  0      msr/smi/
> > > ^C     9.961897866                  0      msr/smi/
> > >
> > > [root@jouet ~]#
> > >
> > > - Arnaldo
> > >
> > > > It's documented in PCH datasheet.
> > > > https://www.intel.com/content/dam/www/public/us/en/
> > > > documents/datasheets/9-series-chipset-pch-datasheet.pdf
> > > >
> > > > APM_CNT-Advanced Power Management Control Port Register I/O
> > Address:
> > > > B2h
> > > > Attribute: R/W
> > > > Default Value: 00h
> > > > Size: 8 bits
> > > > Lockable: No
> > > > Usage: Legacy Only
> > > > Power Well: Core
> > > > Bit Description
> > > > 7:0 Used to pass an APM command between the OS and the SMI handler.
> > > > Writes to this port not only store data in the APMC register, but
> > > > also generates an SMI# when the APMC_EN bit is set.
> > > >
> > > > You can write a byte to port 0xB2 to trigger an SMI#
> > > >
> > > > Thanks,
> > > > Kan

  reply	other threads:[~2017-06-20 20:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 19:05 [PATCH V2 0/2] measure SMI cost (user) kan.liang
2017-05-26 19:05 ` [PATCH V2 1/2] tools lib api fs: Add sysfs__write_int function kan.liang
2017-06-21 18:17   ` [tip:perf/core] " tip-bot for Kan Liang
2017-05-26 19:05 ` [PATCH V2 2/2] perf stat: Add support to measure SMI cost kan.liang
2017-06-21 18:18   ` [tip:perf/core] " tip-bot for Kan Liang
2017-05-29 12:46 ` [PATCH V2 0/2] measure SMI cost (user) Jiri Olsa
2017-05-29 12:52   ` Peter Zijlstra
2017-05-29 13:16     ` Jiri Olsa
2017-05-29 17:06       ` Liang, Kan
2017-06-02 15:45         ` Liang, Kan
2017-06-02 18:27           ` Arnaldo Carvalho de Melo
2017-06-14 17:50             ` Liang, Kan
2017-06-20 13:43               ` Liang, Kan
2017-06-20 20:29                 ` 'Arnaldo Carvalho de Melo' [this message]
2017-06-20 21:43 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620202902.GI13640@kernel.org \
    --to=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=elliott@hpe.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox