From: "Pali Rohár" <pali.rohar@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lee, Chun-Yi" <jlee@suse.com>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH] acer-wmi: Using zero as the first WMI instance number
Date: Tue, 20 Jun 2017 22:46:12 +0200 [thread overview]
Message-ID: <201706202246.12941@pali> (raw)
In-Reply-To: <CAHp75Vd1ZRpZc3P5qnsiWTiURCUSOjsRfPKgShe3seJmsh1GRQ@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1167 bytes --]
On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote:
> On Tue, Jun 20, 2017 at 7:48 PM, Pali Rohár <pali.rohar@gmail.com>
> wrote:
> > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote:
> >> Pali Rohár found that there have some wmi query/evaluation
> >> code that they used 'one' as the first WMI instance number.
> >> But the number is indexed from zero that it's must less than
> >> the instance_count in _WDG.
> >>
> >> This patch changes those instance number from one to zero.
> >>
> >> Cc: Darren Hart <dvhart@infradead.org>
> >> Cc: Andy Shevchenko <andy@infradead.org>
> >> Cc: Pali Rohár <pali.rohar@gmail.com>
> >> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> >
> > Looks good, Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> Unfortunately patchwork ignores this tag.
> So, in the future please:
> - put a tag on a separate line
> - do _not_ prepend it by any characters including white spaces
> (except new line :-) )
I have not known that those lines are parsed automatically.
Will do it in future!
> No need to resend this one.
>
> Pushed to testing, thanks!
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-06-20 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 9:06 [PATCH] acer-wmi: Using zero as the first WMI instance number Lee, Chun-Yi
2017-06-20 16:48 ` Pali Rohár
2017-06-20 17:22 ` Andy Shevchenko
2017-06-20 20:46 ` Pali Rohár [this message]
2017-06-20 21:45 ` Darren Hart
2017-06-21 4:35 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201706202246.12941@pali \
--to=pali.rohar@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox