From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdFUSTs (ORCPT ); Wed, 21 Jun 2017 14:19:48 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48160 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbdFUSTn (ORCPT ); Wed, 21 Jun 2017 14:19:43 -0400 Date: Wed, 21 Jun 2017 11:19:36 -0700 From: "Paul E. McKenney" To: "Luis R. Rodriguez" Cc: peterz@infradead.org, oleg@redhat.com, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, paul.gortmaker@windriver.com, boqun.feng@gmail.com, ebiederm@xmission.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] swait: add idle to make idle-hacks on kthreads explicit Reply-To: paulmck@linux.vnet.ibm.com References: <20170615184820.22994-1-mcgrof@kernel.org> <20170620214548.6602-1-mcgrof@kernel.org> <20170621164846.GD3721@linux.vnet.ibm.com> <20170621175708.GH21846@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621175708.GH21846@wotan.suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17062118-0036-0000-0000-000002324735 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007267; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00877913; UDB=6.00437386; IPR=6.00658054; BA=6.00005434; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015910; XFM=3.00000015; UTC=2017-06-21 18:19:40 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062118-0037-0000-0000-000040D00329 Message-Id: <20170621181936.GP3721@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-21_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706210306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 07:57:08PM +0200, Luis R. Rodriguez wrote: > On Wed, Jun 21, 2017 at 09:48:46AM -0700, Paul E. McKenney wrote: > > On Tue, Jun 20, 2017 at 02:45:45PM -0700, Luis R. Rodriguez wrote: > > > In this proper patch form I've made the non-timeout idle swait void. > > > I've also integrated Paul's comment / ident changes, and added documentation > > > as suggested by Boqun. > > > > > > Let me know if there are issue, otherwise, Paul feel free to take! > > > > Nice docbook comments! I replaced my modified commits with your new ones, > > queued for further review and testing. > > Great thanks! > > > Just out of curiosity, why the three-line swait_event_idle() with the > > "break" statement instead of the two-line version with the inverted > > condition? (I am fine either way, just curious.) > > No strong reason -- just went with what swait.h already used before on > similar condition before, in this case it follows swait_event() model. > In the future it may be possible to share a very nasty macro for both > but since that would involve using a helper function as an argument > I deferred that at this point -- it'd be ugly. Fair enough, works for me! ;-) Thanx, Paul