From: Matthias Kaehlcke <mka@chromium.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Doug Anderson" <dianders@chromium.org>,
"Michal Marek" <mmarek@suse.com>,
"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Grant Grundler" <grundler@chromium.org>,
"Greg Hackmann" <ghackmann@google.com>,
"Michael Davidson" <md@google.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Alexander Potapenko" <glider@google.com>,
"Bernhard Rosenkränzer" <bero@linaro.org>
Subject: Re: [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning
Date: Wed, 21 Jun 2017 14:19:32 -0700 [thread overview]
Message-ID: <20170621211932.GC52338@google.com> (raw)
In-Reply-To: <CAK8P3a1yopRPex3yrKj50cRPy8d3+urGE2XN3aQ61Uu=FE8oVQ@mail.gmail.com>
El Wed, Jun 21, 2017 at 07:59:42PM +0200 Arnd Bergmann ha dit:
> On Wed, Jun 21, 2017 at 6:58 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > El Wed, Jun 21, 2017 at 12:11:55PM +0200 Arnd Bergmann ha dit:
> >> I see that container_of() has been modified in linux-next and no longer adds
> >> the 'const' keyword, do we actually still need the patch?
> >
> > There is still (at least) the case of const arrays passed to
> > MODULE_DEVICE_TABLE.
>
> Does the 'const' have any effect there? As it's just an alias, it
> should at least
> not impact the placement of the symbol in the object file, right?
I agree, it shouldn't make a difference.
> Maybe we can just remove that 'const' too.
Seems worth a try. Do you want to send a patch for the removal?
> Do you see any other instances?
For both x86 and arm64 defconfig the instances are all from
container_of() or MODULE_DEVICE_TABLE.
next prev parent reply other threads:[~2017-06-21 21:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:39 [PATCH 0/2] kbuild: clang: Disable spurious warnings Matthias Kaehlcke
2017-04-21 21:39 ` [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning Matthias Kaehlcke
2017-04-30 13:59 ` Masahiro Yamada
2017-05-02 1:23 ` Matthias Kaehlcke
2017-05-06 16:52 ` Masahiro Yamada
2017-05-08 23:18 ` Matthias Kaehlcke
2017-05-16 6:31 ` Masahiro Yamada
2017-05-16 21:32 ` Doug Anderson
2017-06-22 1:19 ` Masahiro Yamada
2017-04-21 21:39 ` [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning Matthias Kaehlcke
2017-04-30 14:01 ` Masahiro Yamada
2017-05-04 19:50 ` Matthias Kaehlcke
2017-05-08 8:29 ` Masahiro Yamada
2017-05-16 21:41 ` Doug Anderson
2017-05-17 7:35 ` Arnd Bergmann
2017-05-17 18:45 ` Matthias Kaehlcke
2017-05-24 0:04 ` Matthias Kaehlcke
2017-05-24 8:21 ` Arnd Bergmann
2017-06-21 9:11 ` Masahiro Yamada
2017-06-21 10:11 ` Arnd Bergmann
2017-06-21 16:58 ` Matthias Kaehlcke
2017-06-21 17:59 ` Arnd Bergmann
2017-06-21 21:19 ` Matthias Kaehlcke [this message]
2017-07-31 16:35 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621211932.GC52338@google.com \
--to=mka@chromium.org \
--cc=arnd@arndb.de \
--cc=bero@linaro.org \
--cc=dianders@chromium.org \
--cc=ghackmann@google.com \
--cc=glider@google.com \
--cc=grundler@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mmarek@suse.com \
--cc=ndesaulniers@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox