From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbdFVR21 (ORCPT ); Thu, 22 Jun 2017 13:28:27 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdFVR2Z (ORCPT ); Thu, 22 Jun 2017 13:28:25 -0400 Date: Thu, 22 Jun 2017 13:28:23 -0400 (EDT) Message-Id: <20170622.132823.1130047650794574808.davem@davemloft.net> To: arnd@arndb.de Cc: sthemmin@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, sixiao@microsoft.com, devel@linuxdriverproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly From: David Miller In-Reply-To: <20170621221714.278724-1-arnd@arndb.de> References: <20170621221714.278724-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Jun 2017 09:46:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 22 Jun 2017 00:16:37 +0200 > This structure member is hidden behind CONFIG_SYSFS, and we > get a build error when that is disabled: > > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels': > drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh': > drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > > As the value is only set once to the argument of alloc_netdev_mq(), > we can compare against that constant directly. > > Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") > Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels") > Signed-off-by: Arnd Bergmann Applied and queued up for -stable, thank you.