From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753617AbdFVRbS (ORCPT ); Thu, 22 Jun 2017 13:31:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38826 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbdFVRbD (ORCPT ); Thu, 22 Jun 2017 13:31:03 -0400 Date: Thu, 22 Jun 2017 13:30:56 -0400 (EDT) Message-Id: <20170622.133056.934912791314345535.davem@davemloft.net> To: haiyangz@microsoft.com, haiyangz@exchange.microsoft.com Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next,2/2] hv_netvsc: Fix the carrier state error when data path is off From: David Miller In-Reply-To: <1498088447-27282-2-git-send-email-haiyangz@exchange.microsoft.com> References: <1498088447-27282-1-git-send-email-haiyangz@exchange.microsoft.com> <1498088447-27282-2-git-send-email-haiyangz@exchange.microsoft.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Jun 2017 09:49:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Wed, 21 Jun 2017 16:40:47 -0700 > From: Haiyang Zhang > > When the VF NIC is opened, the synthetic NIC's carrier state is set to > off. This tells the host to transitions data path to the VF device. But > if startup script or user manipulates the admin state of the netvsc > device directly for example: > # ifconfig eth0 down > # ifconfig eth0 up > Then the carrier state of the synthetic NIC would be on, even though the > data path was still over the VF NIC. This patch sets the carrier state > of synthetic NIC with consideration of the related VF state. > > Signed-off-by: Haiyang Zhang > Reviewed-by: Stephen Hemminger Applied.