From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752218AbdFVOgg (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Jun 2017 10:36:36 -0400
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47376 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751148AbdFVOge (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Jun 2017 10:36:34 -0400
Date: Thu, 22 Jun 2017 07:36:29 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: remove unused variable in boot_cpu_state_init
Reply-To: paulmck@linux.vnet.ibm.com
References: <20170621215741.4028236-1-arnd@arndb.de>
 <20170621221054.GU3721@linux.vnet.ibm.com>
 <CAK8P3a2V8gPtiNi-_trBOAurcmGATnvpsvSVmSfDaHVM4Y1rxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a2V8gPtiNi-_trBOAurcmGATnvpsvSVmSfDaHVM4Y1rxA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-TM-AS-GCONF: 00
x-cbid: 17062214-2213-0000-0000-000001E55819
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00007272; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000214; SDB=6.00878319; UDB=6.00437630; IPR=6.00658456;
 BA=6.00005437; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015925; XFM=3.00000015;
 UTC=2017-06-22 14:36:31
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17062214-2214-0000-0000-0000569ADB26
Message-Id: <20170622143629.GY3721@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-22_06:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000
 definitions=main-1706220251
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 22, 2017 at 12:15:50AM +0200, Arnd Bergmann wrote:
> On Thu, Jun 22, 2017 at 12:10 AM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> >> Without CONFIG_SMP, we get a harmless warning about
> >> an unused variable:
> >>
> >> kernel/cpu.c: In function 'boot_cpu_state_init':
> >> kernel/cpu.c:1778:6: error: unused variable 'cpu' [-Werror=unused-variable]
> >>
> >> This reworks the function to have the declaration inside
> >> of the #ifdef.
> >>
> >> Fixes: faeb334286b7 ("rcu: Migrate callbacks earlier in the CPU-offline timeline")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I simply added a __maybe_unused in 6441c656acde ("rcu: Migrate callbacks
> > earlier in the CPU-offline timeline") in my -rcu tree.  However, your
> > approach does have the advantage of complaining if the code using that
> > variable is removed.
> >
> > So, would you be OK with my folding your approach into my commit with
> > attribution?
> 
> Sure, that's always best.

Done, thank you!

							Thanx, Paul