From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Tom Rini <trini@konsulko.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement
Date: Thu, 22 Jun 2017 21:14:12 +0200 [thread overview]
Message-ID: <20170622211412.2c9729ab@bbrezillon> (raw)
In-Reply-To: <1498047726-31398-1-git-send-email-trini@konsulko.com>
On Wed, 21 Jun 2017 08:22:06 -0400
Tom Rini <trini@konsulko.com> wrote:
> The binding says that the compatible string must be "ti,am33xx-elm"
> but the code checks only for, and all functioning users set, this as
> "ti,am3352-elm" so correct the binding.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied.
Thanks,
Boris
> ---
> I have submitted a separate patch that correct the dm816x.dtsi to set
> the compatible string there for the elm from ti,816-elm to ti,am3352-elm
> and tested it on the hardware, where it works. It is quite likely that
> dm814x.dtsi can be trivially corrected as it came after dm816x and
> before am335x but as I cannot test the hardware, I did not update that.
> ---
> Documentation/devicetree/bindings/mtd/elm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> index 8c1528c421d4..59ddc61c1076 100644
> --- a/Documentation/devicetree/bindings/mtd/elm.txt
> +++ b/Documentation/devicetree/bindings/mtd/elm.txt
> @@ -1,7 +1,7 @@
> Error location module
>
> Required properties:
> -- compatible: Must be "ti,am33xx-elm"
> +- compatible: Must be "ti,am3352-elm"
> - reg: physical base address and size of the registers map.
> - interrupts: Interrupt number for the elm.
>
prev parent reply other threads:[~2017-06-22 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 12:22 [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement Tom Rini
2017-06-22 19:14 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622211412.2c9729ab@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).