From: Jiri Benc <jbenc@redhat.com>
To: Matthias Schiffer <mschiffer@universe-factory.net>
Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org,
aduyck@mirantis.com, roopa@cumulusnetworks.com,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration
Date: Fri, 23 Jun 2017 10:52:20 +0200 [thread overview]
Message-ID: <20170623105220.18561f34@griffin> (raw)
In-Reply-To: <6e2c8bb77be42834f1da5a3ca79f5e455574a136.1497825555.git.mschiffer@universe-factory.net>
This patchset looks good overall (would send my Acked-by for most of
this but I'm late).
On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
> Log messages in these
> functions are removed, as it is generally unexpected to find error output
> for netlink requests in the kernel log. Userspace should be able to handle
> errors based on the error codes returned via netlink just fine.
However, this is not really true. It's impossible to find out what went
wrong when you use e.g. iproute2 to configure a vxlan link.
We really need to convert the kernel log messages to the extended
netlink errors. Since you removed them prematurely, could you please
work on that?
Thanks,
Jiri
next prev parent reply other threads:[~2017-06-23 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 8:03 [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration Matthias Schiffer
2017-06-23 8:52 ` Jiri Benc [this message]
2017-06-23 10:13 ` Matthias Schiffer
2017-06-23 10:23 ` Johannes Berg
2017-06-23 12:02 ` Matthias Schiffer
2017-06-23 13:31 ` Johannes Berg
2017-06-19 8:03 ` [PATCH net-next v3 2/6] vxlan: get rid of redundant vxlan_dev.flags Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 3/6] vxlan: improve validation of address family configuration Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 4/6] vxlan: check valid combinations of address scopes Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 5/6] vxlan: fix snooping for link-local IPv6 addresses Matthias Schiffer
2017-06-19 8:04 ` [PATCH net-next v3 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses Matthias Schiffer
2017-06-20 17:37 ` [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623105220.18561f34@griffin \
--to=jbenc@redhat.com \
--cc=aduyck@mirantis.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox