From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbdFWNBf (ORCPT ); Fri, 23 Jun 2017 09:01:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:60828 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750932AbdFWNBe (ORCPT ); Fri, 23 Jun 2017 09:01:34 -0400 Date: Fri, 23 Jun 2017 15:01:31 +0200 From: Johannes Thumshirn To: Yadan Fan Cc: don.brace@microsemi.com, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hpsa: limit transfer length to 1MB Message-ID: <20170623130131.GD13014@linux-x5ow.site> References: <20170623094006.16807-1-ydfan@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170623094006.16807-1-ydfan@suse.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2017 at 05:40:05PM +0800, Yadan Fan wrote: > The hpsa firmware will bypass the cache for any request larger > than 1MB, so we should cap the request size to avoid any > performance degradation in kernels later than v4.3 > > This degradation is caused from d2be537c3ba3568acd79cd178327b842e60d035e, > which changed max_sectors_kb to 1280k, but the hardware is able to > work fine with it, so the true fix should be from hpsa driver. > > Signed-off-by: Yadan Fan > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850