From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jim Davis <jim.epost@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion
Date: Fri, 23 Jun 2017 13:39:51 -0600 [thread overview]
Message-ID: <20170623133951.49bf28f8@lwn.net> (raw)
In-Reply-To: <20170619074906.250920c8@vento.lan>
On Mon, 19 Jun 2017 07:49:06 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> There's a catch, though: as sphinxsetup hmargin/vmargin was added
> only on Sphinx version 1.5.3, the enclosed patch won't adjust the
> margins for versions 1.5.0 to 1.5.2. While I didn't test, I bet it
> will just ignore the keys, showing some warning.
And people routinely accuse *me* of being overly optimistic...
> ! Package keyval Error: hmargin undefined.
>
> See the keyval package documentation for explanation.
> Type H <return> for immediate help.
> ...
>
> l.19 \sphinxsetup{hmargin=0.5in, vmargin=0.5in}
>
> ?
So it kills the build on 1.5.2.
I've made a tweak to special-case early 1.5.x.
> Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> Sighed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Sighed-off-by indeed, I agree. It's a good thing there's a lot of beer in
the fridge...
jon
next prev parent reply other threads:[~2017-06-23 19:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 23:46 [PATCH 0/5] Make PDF builds work again Jonathan Corbet
2017-06-18 23:46 ` [PATCH 1/5] Docs: Include the Latex "ifthen" package Jonathan Corbet
2017-06-18 23:46 ` [PATCH 2/5] Docs: Remove redundant geometry package inclusion Jonathan Corbet
2017-06-19 10:30 ` Mauro Carvalho Chehab
2017-06-19 10:49 ` Mauro Carvalho Chehab
2017-06-23 19:39 ` Jonathan Corbet [this message]
2017-06-23 21:26 ` Mauro Carvalho Chehab
2017-06-18 23:46 ` [PATCH 3/5] Docs: fix table problems in ras.rst Jonathan Corbet
2017-06-18 23:46 ` [PATCH 4/5] Docs: Use kernel-figure in vidioc-g-selection.rst Jonathan Corbet
2017-06-18 23:46 ` [PATCH 5/5] DRM: Fix an incorrectly formatted table Jonathan Corbet
2017-06-18 23:48 ` [PATCH 0/5] Make PDF builds work again Jonathan Corbet
2017-06-19 1:18 ` Mauro Carvalho Chehab
2017-06-19 14:43 ` Mauro Carvalho Chehab
2017-07-03 8:25 ` Daniel Vetter
2017-07-03 12:44 ` Jonathan Corbet
2017-07-05 21:22 ` Jim Davis
2017-07-06 8:28 ` Markus Heiser
2017-07-06 9:54 ` Mauro Carvalho Chehab
2017-07-05 20:03 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623133951.49bf28f8@lwn.net \
--to=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=jim.epost@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox