public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tommy Nguyen <remyabel@gmail.com>
Cc: "Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE
Date: Sun, 25 Jun 2017 14:56:02 +0200	[thread overview]
Message-ID: <20170625125602.GC2728@kroah.com> (raw)
In-Reply-To: <20170625122206.4229-1-remyabel@gmail.com>

On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote:
> Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE
> and debugfs_create_file_unsafe should be used instead.

Why use the _unsafe version?  Are you sure it will work properly?  What
benifit does it offer?

> 
> Signed-off-by: Tommy Nguyen <remyabel@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 03d3a4f..8f96b38 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
> -			debug_shrink_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
> +			 debug_shrink_set, "%llu\n");

Are you sure this works?

thanks,

greg k-h

  reply	other threads:[~2017-06-25 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 12:22 [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE Tommy Nguyen
2017-06-25 12:56 ` Greg Kroah-Hartman [this message]
2017-06-27 17:44 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170625125602.GC2728@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=remyabel@gmail.com \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox