From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdFYM4K (ORCPT ); Sun, 25 Jun 2017 08:56:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56784 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdFYM4J (ORCPT ); Sun, 25 Jun 2017 08:56:09 -0400 Date: Sun, 25 Jun 2017 14:56:02 +0200 From: Greg Kroah-Hartman To: Tommy Nguyen Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20170625125602.GC2728@kroah.com> References: <20170625122206.4229-1-remyabel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170625122206.4229-1-remyabel@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead. Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by: Tommy Nguyen > --- > drivers/staging/android/ion/ion.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 03d3a4f..8f96b38 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, > - debug_shrink_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, > + debug_shrink_set, "%llu\n"); Are you sure this works? thanks, greg k-h