* [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning
@ 2017-06-23 2:21 AbdAllah-MEZITI
2017-06-25 14:39 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: AbdAllah-MEZITI @ 2017-06-23 2:21 UTC (permalink / raw)
To: gregkh
Cc: Sergio Paracuellos, Juliana Rodrigues, Andrea della Porta,
Frans Klaver, Shiva Kerdel, sayli karnik, Rehas Sachdeva, devel,
linux-kernel
drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:188:25: expected unsigned short [unsigned] [addressable] [usertype] tx_rate
drivers/staging/wlan-ng/prism2mgmt.c:188:25: got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:200:30: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:200:30: expected unsigned short [unsigned] [addressable] [usertype] channel_list
drivers/staging/wlan-ng/prism2mgmt.c:200:30: got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:203:26: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:203:26: expected unsigned short [unsigned] [addressable] [usertype] len
drivers/staging/wlan-ng/prism2mgmt.c:203:26: got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:232:28: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:232:28: expected unsigned short [unsigned] [short] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:232:28: got restricted __le16 [usertype] <noident>
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 60110b4..1dc6ed8 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -358,7 +358,7 @@ struct hfa384x_bytestr {
} __packed;
struct hfa384x_bytestr32 {
- u16 len;
+ __le16 len;
u8 data[32];
} __packed;
@@ -399,8 +399,8 @@ struct hfa384x_caplevel {
/*-- Configuration Record: HostScanRequest (data portion only) --*/
struct hfa384x_host_scan_request_data {
- u16 channel_list;
- u16 tx_rate;
+ __le16 channel_list;
+ __le16 tx_rate;
struct hfa384x_bytestr32 ssid;
} __packed;
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index f4d6e48..c4aa9e7 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -213,7 +213,7 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
goto exit;
}
if (word == HFA384x_PORTSTATUS_DISABLED) {
- u16 wordbuf[17];
+ __le16 wordbuf[17];
result = hfa384x_drvr_setconfig16(hw,
HFA384x_RID_CNFROAMINGMODE,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning
2017-06-23 2:21 [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning AbdAllah-MEZITI
@ 2017-06-25 14:39 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-06-25 14:39 UTC (permalink / raw)
To: AbdAllah-MEZITI
Cc: Sergio Paracuellos, Juliana Rodrigues, Andrea della Porta,
Frans Klaver, Shiva Kerdel, sayli karnik, Rehas Sachdeva, devel,
linux-kernel
On Fri, Jun 23, 2017 at 04:21:54AM +0200, AbdAllah-MEZITI wrote:
> drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in assignment (different base types)
> drivers/staging/wlan-ng/prism2mgmt.c:188:25: expected unsigned short [unsigned] [addressable] [usertype] tx_rate
> drivers/staging/wlan-ng/prism2mgmt.c:188:25: got restricted __le16 [usertype] <noident>
> drivers/staging/wlan-ng/prism2mgmt.c:200:30: warning: incorrect type in assignment (different base types)
> drivers/staging/wlan-ng/prism2mgmt.c:200:30: expected unsigned short [unsigned] [addressable] [usertype] channel_list
> drivers/staging/wlan-ng/prism2mgmt.c:200:30: got restricted __le16 [usertype] <noident>
> drivers/staging/wlan-ng/prism2mgmt.c:203:26: warning: incorrect type in assignment (different base types)
> drivers/staging/wlan-ng/prism2mgmt.c:203:26: expected unsigned short [unsigned] [addressable] [usertype] len
> drivers/staging/wlan-ng/prism2mgmt.c:203:26: got restricted __le16 [usertype] <noident>
> drivers/staging/wlan-ng/prism2mgmt.c:232:28: warning: incorrect type in assignment (different base types)
> drivers/staging/wlan-ng/prism2mgmt.c:232:28: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/wlan-ng/prism2mgmt.c:232:28: got restricted __le16 [usertype] <noident>
>
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 6 +++---
> drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Does not apply to my staging-next branch at all :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-25 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-23 2:21 [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning AbdAllah-MEZITI
2017-06-25 14:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox