* [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint
@ 2017-06-02 11:35 Henri Roosen
2017-06-25 21:35 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Henri Roosen @ 2017-06-02 11:35 UTC (permalink / raw)
To: linux-remoteproc; +Cc: Henri Roosen, Ohad Ben-Cohen, Bjorn Andersson, open list
A device might not have an endpoint assigned. This patch checks if
rpdev->ept has a value before dereferencing or using it.
Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index 5e66e081..3c582f2 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -314,7 +314,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev)
int err = 0;
/* need to tell remote processor's name service about this channel ? */
- if (rpdev->announce &&
+ if (rpdev->announce && rpdev->ept &&
virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
struct rpmsg_ns_msg nsm;
@@ -338,7 +338,7 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev)
int err = 0;
/* tell remote processor's name service we're removing this channel */
- if (rpdev->announce &&
+ if (rpdev->announce && rpdev->ept &&
virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
struct rpmsg_ns_msg nsm;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint
2017-06-02 11:35 [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint Henri Roosen
@ 2017-06-25 21:35 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2017-06-25 21:35 UTC (permalink / raw)
To: Henri Roosen; +Cc: linux-remoteproc, Ohad Ben-Cohen, open list
On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote:
> A device might not have an endpoint assigned. This patch checks if
> rpdev->ept has a value before dereferencing or using it.
>
Applied, thanks.
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 5e66e081..3c582f2 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -314,7 +314,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev)
> int err = 0;
>
> /* need to tell remote processor's name service about this channel ? */
> - if (rpdev->announce &&
> + if (rpdev->announce && rpdev->ept &&
> virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
> struct rpmsg_ns_msg nsm;
>
> @@ -338,7 +338,7 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev)
> int err = 0;
>
> /* tell remote processor's name service we're removing this channel */
> - if (rpdev->announce &&
> + if (rpdev->announce && rpdev->ept &&
> virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
> struct rpmsg_ns_msg nsm;
>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-25 21:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-02 11:35 [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint Henri Roosen
2017-06-25 21:35 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox