From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbdFZQkY (ORCPT ); Mon, 26 Jun 2017 12:40:24 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34682 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbdFZQkU (ORCPT ); Mon, 26 Jun 2017 12:40:20 -0400 Date: Mon, 26 Jun 2017 09:40:16 -0700 From: Dmitry Torokhov To: Rob Herring Cc: Jeffy Chen , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, Mark Brown , linux-spi@vger.kernel.org, Mark Rutland Subject: Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property Message-ID: <20170626164016.GA4965@dtor-ws> References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-3-git-send-email-jeffy.chen@rock-chips.com> <20170626160011.qi3bliz5jt6d5wgb@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170626160011.qi3bliz5jt6d5wgb@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2017 at 11:00:11AM -0500, Rob Herring wrote: > On Wed, Jun 21, 2017 at 06:01:49PM +0800, Jeffy Chen wrote: > > Update document devicetree bindings to support "wakeup-source" property. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v3: None > > > > Documentation/devicetree/bindings/spi/spi-bus.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt > > index 1f6e86f..0fa1ccf 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-bus.txt > > +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt > > @@ -77,6 +77,7 @@ All slave nodes can contain the following optional properties: > > Defaults to 1 if not present. > > - spi-rx-delay-us - Microsecond delay after a read transfer. > > - spi-tx-delay-us - Microsecond delay after a write transfer. > > +- wakeup-source - Device can be used as a wakeup source. > > wakeup-source is valid for any device with an interrupts property > already, so I don't think this is necessary. Do you mean it is not necessary on SPI level or not necessary at all? Or you disagree with wording? Because we do need a way to say that on given platform the device is supposed to be configured as a wakeup source. Thanks. -- Dmitry