From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbdFZQyV (ORCPT ); Mon, 26 Jun 2017 12:54:21 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:51164 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdFZQyP (ORCPT ); Mon, 26 Jun 2017 12:54:15 -0400 Date: Mon, 26 Jun 2017 18:53:09 +0200 From: Florian Westphal To: Lin Zhang Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension Message-ID: <20170626165309.GM29636@breakpoint.cc> References: <1498457446-30135-1-git-send-email-xiaolou4617@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498457446-30135-1-git-send-email-xiaolou4617@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lin Zhang wrote: > In the current conntrack extend code, if we want to add a new > extension, we must be add a new extension id and recompile kernel. > I think that is not be convenient for users, so i add a new extension named > NF_CT_EXT_EXPAND for supporting dynamic register/unregister expansion > in runtime that means if kernel support NF_CT_EXT_EXPAND extension, > user could call nf_ct_expand_area_add() to register a new expansion > but not need to predefine an id in enum nf_ct_ext_id. We never did this because its only required for out of tree modules. I would prefer if such extensions are discussed/proposed on nf-devel instead, and then, if there is agreement that the extension is useful, it can be submitted for inclusion in mainline kernel instead.