* [PATCH] arm: perf: make of_device_ids const
@ 2017-06-27 6:12 Arvind Yadav
2017-06-27 8:39 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-06-27 6:12 UTC (permalink / raw)
To: will.deacon, mark.rutland, peterz, mingo, acme,
alexander.shishkin, linux
Cc: linux-arm-kernel, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/arm/kernel/perf_event_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event_v6.c b/arch/arm/kernel/perf_event_v6.c
index 96b7a47..8226d0b 100644
--- a/arch/arm/kernel/perf_event_v6.c
+++ b/arch/arm/kernel/perf_event_v6.c
@@ -552,7 +552,7 @@ static int armv6mpcore_pmu_init(struct arm_pmu *cpu_pmu)
return 0;
}
-static struct of_device_id armv6_pmu_of_device_ids[] = {
+static const struct of_device_id armv6_pmu_of_device_ids[] = {
{.compatible = "arm,arm11mpcore-pmu", .data = armv6mpcore_pmu_init},
{.compatible = "arm,arm1176-pmu", .data = armv6_1176_pmu_init},
{.compatible = "arm,arm1136-pmu", .data = armv6_1136_pmu_init},
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm: perf: make of_device_ids const
2017-06-27 6:12 [PATCH] arm: perf: make of_device_ids const Arvind Yadav
@ 2017-06-27 8:39 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2017-06-27 8:39 UTC (permalink / raw)
To: Arvind Yadav
Cc: mark.rutland, peterz, mingo, acme, alexander.shishkin, linux,
linux-arm-kernel, linux-kernel
On Tue, Jun 27, 2017 at 11:42:21AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> arch/arm/kernel/perf_event_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This is already queued in -next.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm: perf: make of_device_ids const
@ 2017-06-15 9:25 Arvind Yadav
0 siblings, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-06-15 9:25 UTC (permalink / raw)
To: peterz, mingo, acme, alexander.shishkin, will.deacon,
mark.rutland, linux
Cc: linux-kernel, linux-arm-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/arm/kernel/perf_event_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event_v6.c b/arch/arm/kernel/perf_event_v6.c
index 96b7a47..8226d0b 100644
--- a/arch/arm/kernel/perf_event_v6.c
+++ b/arch/arm/kernel/perf_event_v6.c
@@ -552,7 +552,7 @@ static int armv6mpcore_pmu_init(struct arm_pmu *cpu_pmu)
return 0;
}
-static struct of_device_id armv6_pmu_of_device_ids[] = {
+static const struct of_device_id armv6_pmu_of_device_ids[] = {
{.compatible = "arm,arm11mpcore-pmu", .data = armv6mpcore_pmu_init},
{.compatible = "arm,arm1176-pmu", .data = armv6_1176_pmu_init},
{.compatible = "arm,arm1136-pmu", .data = armv6_1136_pmu_init},
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-27 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-27 6:12 [PATCH] arm: perf: make of_device_ids const Arvind Yadav
2017-06-27 8:39 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2017-06-15 9:25 Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox