* [PATCH] KVM: Replaces symbolic permissions with numeric
@ 2017-06-27 9:51 Roman Storozhenko
2017-06-27 13:08 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Roman Storozhenko @ 2017-06-27 9:51 UTC (permalink / raw)
To: kvm; +Cc: pbonzini, rkrcmar, linux-kernel
Replaces "S_IRUGO | S_IWUSR" with 0644. The reason is that symbolic
permissions considered harmful:
https://lwn.net/Articles/696229/
Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
virt/kvm/kvm_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index f0fe9d0..3863cf7 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -73,17 +73,17 @@ MODULE_LICENSE("GPL");
/* Architectures should define their poll value according to the halt latency */
unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
-module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns);
/* Default doubles per-vcpu halt_poll_ns. */
unsigned int halt_poll_ns_grow = 2;
-module_param(halt_poll_ns_grow, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns_grow, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns_grow);
/* Default resets per-vcpu halt_poll_ns . */
unsigned int halt_poll_ns_shrink;
-module_param(halt_poll_ns_shrink, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns_shrink, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: Replaces symbolic permissions with numeric
2017-06-27 9:51 [PATCH] KVM: Replaces symbolic permissions with numeric Roman Storozhenko
@ 2017-06-27 13:08 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2017-06-27 13:08 UTC (permalink / raw)
To: Roman Storozhenko, kvm; +Cc: rkrcmar, linux-kernel
On 27/06/2017 11:51, Roman Storozhenko wrote:
> Replaces "S_IRUGO | S_IWUSR" with 0644. The reason is that symbolic
> permissions considered harmful:
> https://lwn.net/Articles/696229/
>
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> virt/kvm/kvm_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f0fe9d0..3863cf7 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -73,17 +73,17 @@ MODULE_LICENSE("GPL");
>
> /* Architectures should define their poll value according to the halt latency */
> unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
> -module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns);
>
> /* Default doubles per-vcpu halt_poll_ns. */
> unsigned int halt_poll_ns_grow = 2;
> -module_param(halt_poll_ns_grow, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_grow, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns_grow);
>
> /* Default resets per-vcpu halt_poll_ns . */
> unsigned int halt_poll_ns_shrink;
> -module_param(halt_poll_ns_shrink, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_shrink, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);
>
> /*
>
Queued, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-27 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-27 9:51 [PATCH] KVM: Replaces symbolic permissions with numeric Roman Storozhenko
2017-06-27 13:08 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox