From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbdF0OUj (ORCPT ); Tue, 27 Jun 2017 10:20:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52336 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbdF0OQ2 (ORCPT ); Tue, 27 Jun 2017 10:16:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F0F996071A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach' From: Kalle Valo In-Reply-To: <20170621054553.16546-1-christophe.jaillet@wanadoo.fr> References: <20170621054553.16546-1-christophe.jaillet@wanadoo.fr> To: Christophe Jaillet Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, rafal@milecki.pl, pieter-paul.giesberts@broadcom.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , stable@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170627141616.F24176071A@smtp.codeaurora.org> Date: Tue, 27 Jun 2017 14:16:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Jaillet wrote: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. > > Cc: stable@vger.kernel.org > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") > Signed-off-by: Christophe JAILLET Patch applied to wireless-drivers-next.git, thanks. 57c00f2fac51 brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach' -- https://patchwork.kernel.org/patch/9800763/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches