From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753105AbdF0NeO (ORCPT ); Tue, 27 Jun 2017 09:34:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:39381 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752112AbdF0NeG (ORCPT ); Tue, 27 Jun 2017 09:34:06 -0400 Date: Tue, 27 Jun 2017 15:34:03 +0200 From: Jean Delvare To: Sudip Mukherjee Cc: Guenter Roeck , linux-kernel@vger.kernel.org, Fenghua Yu , linux-hwmon@vger.kernel.org Subject: Re: userspace regression with hwmon Message-ID: <20170627153403.18f1f09e@endymion> In-Reply-To: <5ce4bea5-008a-8a86-cdf4-83d0f427126c@roeck-us.net> References: <20170626143320.GA1976@sudip-tp> <20170626170611.GC20491@roeck-us.net> <20170627122300.GA14227@sudip-tp> <5ce4bea5-008a-8a86-cdf4-83d0f427126c@roeck-us.net> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jun 2017 05:52:39 -0700, Guenter Roeck wrote: > On 06/27/2017 05:23 AM, Sudip Mukherjee wrote: > > Well, using the raw platform device path was a bad design decision. > > But I still see a difference. In v3.8 all the temp* nodes were in > > /sys/class/hwmon/hwmon0/device/ but in v4.4 I can see that they are in > > /sys/class/hwmon/hwmon0/. So if we do modify the code, then we still > > need to have two versions of userspace code based on the kernel. > > Your code should check for the 'name' attribute in both locations. ... as libsensors does. If you just do what libsensors does, you'll be on the safe side. -- Jean Delvare SUSE L3 Support