From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbdF0RPp (ORCPT ); Tue, 27 Jun 2017 13:15:45 -0400 Received: from foss.arm.com ([217.140.101.70]:60940 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbdF0RPh (ORCPT ); Tue, 27 Jun 2017 13:15:37 -0400 Date: Tue, 27 Jun 2017 18:14:45 +0100 From: Mark Rutland To: Doug Berger Cc: Laura Abbott , linux@armlinux.org.uk, nicolas.pitre@linaro.org, tixy@linaro.org, f.fainelli@gmail.com, keescook@chromium.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: memblock limit must be pmd-aligned Message-ID: <20170627171445.GG30002@leverpostej> References: <20170626172315.26369-1-opendmb@gmail.com> <48116220-b89b-7413-ea62-c78dfb0594a2@redhat.com> <129544df-5461-a877-84c9-9889bd5e9dc0@gmail.com> <20170627105912.GE30002@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2017 at 09:57:17AM -0700, Doug Berger wrote: > On 06/27/2017 03:59 AM, Mark Rutland wrote: > > On Mon, Jun 26, 2017 at 05:50:03PM -0700, Doug Berger wrote: > >> On 06/26/2017 04:43 PM, Laura Abbott wrote: > >>> On 06/26/2017 10:23 AM, Doug Berger wrote: > >>>> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > >>>> index 31af3cb59a60..2ae4f9c9d757 100644 > >>>> --- a/arch/arm/mm/mmu.c > >>>> +++ b/arch/arm/mm/mmu.c > >>>> @@ -1226,7 +1226,7 @@ void __init adjust_lowmem_bounds(void) > >>>> if (memblock_limit) > >>>> memblock_limit = round_down(memblock_limit, PMD_SIZE); > >>>> if (!memblock_limit) > >>>> - memblock_limit = arm_lowmem_limit; > >>>> + memblock_limit = round_down(arm_lowmem_limit, PMD_SIZE); > >>>> > > > > Given we're always going to do the rounding, how about we move that out > > of the existing conditional, i.e. get rid of the first if, and have: > > > > if (!memblock_limit) > > memblock_limit = arm_lowmem_limit; > > > > /* > > * Round the memblock limit down to a pmd size. This > > * helps to ensure that we will allocate memory from the > > * last full pmd, which should be mapped. > > */ > > memblock_limit = round_down(memblock_limit, PMD_SIZE); > > > > Thanks, > > Mark. > That makes perfect sense to me. I will submit a v2 with this code > change. Should I add your Signed-off-by since it is your change? Since you're writing the patch, there's no need. Feel free to add my Suggested-by if you want, but I'm not too worried either way. Thanks, Mark.