From: Will Deacon <will.deacon@arm.com>
To: Borislav Petkov <bp@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Tyler Baicar <tbaicar@codeaurora.org>,
Xie XiuQi <xiexiuqi@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ras: mark stub functions as 'inline'
Date: Wed, 28 Jun 2017 11:28:54 +0100 [thread overview]
Message-ID: <20170628102854.GC11053@arm.com> (raw)
In-Reply-To: <20170628102744.d5cfareszn4g26ka@pd.tnic>
On Wed, Jun 28, 2017 at 12:27:44PM +0200, Borislav Petkov wrote:
> On Tue, Jun 27, 2017 at 05:35:41PM +0200, Arnd Bergmann wrote:
> > With CONFIG_RAS disabled, we get two harmless warnings about
> > unused functions:
> >
> > include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
> > static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
> > include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
> > static void log_non_standard_event(const guid_t *sec_type,
> >
> > Clearly these are meant to be 'inline', like the other stubs
> > in the same header.
> >
> > Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
> > Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > include/linux/ras.h | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> I'm assuming Will is picking this one up along with the rest of the ARM
> RAS pile...
Yup, will do. Thanks.
Will
prev parent reply other threads:[~2017-06-28 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 15:35 [PATCH] ras: mark stub functions as 'inline' Arnd Bergmann
2017-06-28 10:27 ` Borislav Petkov
2017-06-28 10:28 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628102854.GC11053@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tbaicar@codeaurora.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox