From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbdF1K3B (ORCPT ); Wed, 28 Jun 2017 06:29:01 -0400 Received: from foss.arm.com ([217.140.101.70]:39946 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbdF1K2z (ORCPT ); Wed, 28 Jun 2017 06:28:55 -0400 Date: Wed, 28 Jun 2017 11:28:54 +0100 From: Will Deacon To: Borislav Petkov Cc: Arnd Bergmann , Tyler Baicar , Xie XiuQi , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ras: mark stub functions as 'inline' Message-ID: <20170628102854.GC11053@arm.com> References: <20170627153603.1358341-1-arnd@arndb.de> <20170628102744.d5cfareszn4g26ka@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628102744.d5cfareszn4g26ka@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2017 at 12:27:44PM +0200, Borislav Petkov wrote: > On Tue, Jun 27, 2017 at 05:35:41PM +0200, Arnd Bergmann wrote: > > With CONFIG_RAS disabled, we get two harmless warnings about > > unused functions: > > > > include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function] > > static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; } > > include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function] > > static void log_non_standard_event(const guid_t *sec_type, > > > > Clearly these are meant to be 'inline', like the other stubs > > in the same header. > > > > Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section") > > Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event") > > Signed-off-by: Arnd Bergmann > > --- > > include/linux/ras.h | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > Acked-by: Borislav Petkov > > I'm assuming Will is picking this one up along with the rest of the ARM > RAS pile... Yup, will do. Thanks. Will