From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbdF1N2b (ORCPT ); Wed, 28 Jun 2017 09:28:31 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:37830 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbdF1N2N (ORCPT ); Wed, 28 Jun 2017 09:28:13 -0400 Date: Wed, 28 Jun 2017 15:27:50 +0200 From: Andrew Lunn To: Lin Yun Sheng Cc: davem@davemloft.net, f.fainelli@gmail.com, huangdaode@hisilicon.com, xuwei5@hisilicon.com, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, gabriele.paoloni@huawei.com, john.garry@huawei.com, linuxarm@huawei.com, salil.mehta@huawei.com, lipeng321@huawei.com, tremyfr@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH NET V7 1/2] net: phy: Add phy loopback support in net phy framework Message-ID: <20170628132750.GA12559@lunn.ch> References: <1498641191-13343-1-git-send-email-linyunsheng@huawei.com> <1498641191-13343-2-git-send-email-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498641191-13343-2-git-send-email-linyunsheng@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2017 at 05:13:10PM +0800, Lin Yun Sheng wrote: > This patch add set_loopback in phy_driver, which is used by MAC > driver to enable or disable phy loopback. it also add a generic > genphy_loopback function, which use BMCR loopback bit to enable > or disable loopback. > > Signed-off-by: Lin Yun Sheng Hi Lin It is normal to include my Reviewed-by: Andrew Lunn when resubmitting a patch. The only time you drop such tags is when you make a big change. Andrew