From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751920AbdF1REX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Jun 2017 13:04:23 -0400
Received: from mga14.intel.com ([192.55.52.115]:55559 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751492AbdF1REO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Jun 2017 13:04:14 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,276,1496127600"; 
   d="scan'208";a="1165730354"
Date: Wed, 28 Jun 2017 13:10:31 -0400
From: Keith Busch <keith.busch@intel.com>
To: wenxiong@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, axboe@fb.com, bjking@linux.vnet.ibm.com,
        hch@lst.de
Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF
 enabled
Message-ID: <20170628171031.GC2650@localhost.localdomain>
References: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 28, 2017 at 11:32:51AM -0500, wenxiong@linux.vnet.ibm.com wrote:
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 519599d..e871444 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
>  
>  	if (unlikely(bio.bi_error))
>  		return bio.bi_error;
> +
> +	if (bio_integrity(&bio))
> +		bio_integrity_free(&bio);
> +
>  	return ret;
>  }

We don't want to leak the integrity payload in case of bi_error either.