From: Guenter Roeck <linux@roeck-us.net>
To: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Cc: wim@iguana.be, robh+dt@kernel.org, mark.rutland@arm.com,
joel@jms.id.au, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config
Date: Wed, 28 Jun 2017 10:52:16 -0700 [thread overview]
Message-ID: <20170628175216.GA13730@roeck-us.net> (raw)
In-Reply-To: <a3f76a4e-6c44-9844-9840-f6b5b05255ed@linux.vnet.ibm.com>
On Wed, Jun 28, 2017 at 11:09:15AM -0500, Christopher Bostic wrote:
>
> >>
> >>Why would there even be a need configure for no system reset? The external
> >>mode 'wdt ext: External signal enable after timeout' can be sent off chip
> >>even if system reset is disabled. The watchdog is doing something in this
> >>case and would require wdt instantiation.
> >>
> >Wouldn't that be "aspeed,external-signal" ?
> Yes that optional parameter would need to be specified in that situation, as
> well as 'aspeed,no-system-reset'.
>
Ok, makes sense (after looking into the datasheet). The missing detail
is that there is a separate configuration bit for "Reset system after
timeout", which is set in addition to reset_{sys,soc,arm}.
Thanks,
Guenter
prev parent reply other threads:[~2017-06-28 17:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 21:17 [PATCH v2 0/2] Add ASPEED watchdog device tree properties Christopher Bostic
2017-06-27 21:17 ` [PATCH v2 1/2] drivers/watchdog: Add optional ASPEED " Christopher Bostic
2017-06-27 21:32 ` Guenter Roeck
2017-06-27 21:42 ` Christopher Bostic
2017-06-27 22:07 ` Guenter Roeck
2017-06-28 14:55 ` Christopher Bostic
2017-06-28 15:06 ` Guenter Roeck
2017-06-27 21:17 ` [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config Christopher Bostic
2017-06-28 11:31 ` Guenter Roeck
2017-06-28 14:29 ` Christopher Bostic
2017-06-28 14:54 ` Guenter Roeck
2017-06-28 14:59 ` Christopher Bostic
2017-06-28 15:08 ` Guenter Roeck
2017-06-28 15:55 ` Christopher Bostic
2017-06-28 16:06 ` Guenter Roeck
2017-06-28 16:09 ` Christopher Bostic
2017-06-28 17:52 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628175216.GA13730@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cbostic@linux.vnet.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox