From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com,
rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>
Subject: Re: [PATCH V4 07/12] cgroup: export fhandle info for a cgroup
Date: Wed, 28 Jun 2017 14:12:56 -0400 [thread overview]
Message-ID: <20170628181256.GC24647@htj.duckdns.org> (raw)
In-Reply-To: <a81d74a4e19be95207d7455ec9abb4fb0b4d1736.1498666964.git.shli@fb.com>
On Wed, Jun 28, 2017 at 09:29:57AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
>
> Add an API to export cgroup fhandle info. We don't export a full 'struct
> file_handle', there are unrequired info. Sepcifically, cgroup is always
> a directory, so we don't need a 'FILEID_INO32_GEN_PARENT' type fhandle,
> we only need export the inode number and generation number just like
> what generic_fh_to_dentry does. And we can avoid the overhead of getting
> an inode too, since kernfs_node_id (ino and generation) has all the info
> required.
>
> Signed-off-by: Shaohua Li <shli@fb.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2017-06-28 18:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 16:29 [PATCH V4 00/12] blktrace: output cgroup info Shaohua Li
2017-06-28 16:29 ` [PATCH V4 01/12] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 02/12] kernfs: implement i_generation Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 03/12] kernfs: add an API to get kernfs node from inode number Shaohua Li
2017-06-28 18:07 ` Tejun Heo
2017-06-29 12:50 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 05/12] kernfs: introduce kernfs_node_id Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 06/12] kernfs: add exportfs operations Shaohua Li
2017-06-29 12:50 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 07/12] cgroup: export fhandle info for a cgroup Shaohua Li
2017-06-28 18:12 ` Tejun Heo [this message]
2017-06-28 16:29 ` [PATCH V4 08/12] blktrace: export cgroup info in trace Shaohua Li
2017-06-28 16:56 ` Steven Rostedt
2017-06-28 16:29 ` [PATCH V4 09/12] block: always attach cgroup info into bio Shaohua Li
2017-06-28 16:30 ` [PATCH V4 10/12] block: call __bio_free in bio_endio Shaohua Li
2017-06-28 21:29 ` Christoph Hellwig
2017-06-28 21:42 ` Shaohua Li
2017-06-29 17:15 ` Christoph Hellwig
2017-06-29 18:35 ` Shaohua Li
2017-06-29 20:22 ` Christoph Hellwig
2017-06-28 16:30 ` [PATCH V4 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li
2017-06-28 16:41 ` Jens Axboe
2017-06-28 16:30 ` [PATCH V4 12/12] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li
2017-06-28 16:43 ` [PATCH V4 00/12] blktrace: output cgroup info Jens Axboe
2017-06-28 16:53 ` Shaohua Li
2017-06-28 16:54 ` Jens Axboe
2017-06-28 18:11 ` Tejun Heo
2017-06-28 20:57 ` Jens Axboe
2017-06-28 21:25 ` Tejun Heo
2017-06-29 12:50 ` Greg KH
2017-06-29 18:39 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628181256.GC24647@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox