From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751786AbdF2BQr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Jun 2017 21:16:47 -0400
Received: from foss.arm.com ([217.140.101.70]:50018 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751639AbdF2BQl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Jun 2017 21:16:41 -0400
Date: Wed, 28 Jun 2017 20:16:38 -0500
From: Kim Phillips <kim.phillips@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: <robh@kernel.org>, <mathieu.poirier@linaro.org>, <pawel.moll@arm.com>,
        <suzuki.poulose@arm.com>, <marc.zyngier@arm.com>,
        Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
        <alexander.shishkin@linux.intel.com>, <peterz@infradead.org>,
        <mingo@redhat.com>, <tglx@linutronix.de>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 0/5] Add support for the ARMv8.2 Statistical
 Profiling Extension
Message-Id: <20170628201638.01204c14719514217433e82d@arm.com>
In-Reply-To: <20170628113249.GF5981@leverpostej>
References: <1496676177-29356-1-git-send-email-will.deacon@arm.com>
        <20170612110823.GA27319@leverpostej>
        <20170612112048.69561e8d067488e8689de755@arm.com>
        <20170615105735.b89183a9190a261d3b8d132a@arm.com>
        <20170621153108.GC6041@arm.com>
        <20170622105640.c444b8b0f16266ba2c3ce304@arm.com>
        <20170622183620.GJ15336@arm.com>
        <20170627160758.cdaebc3e7f0cd88455e07763@arm.com>
        <20170628112601.GD5981@leverpostej>
        <20170628113249.GF5981@leverpostej>
Organization: ARM
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 28 Jun 2017 12:32:50 +0100
Mark Rutland <mark.rutland@arm.com> wrote:

> On Wed, Jun 28, 2017 at 12:26:02PM +0100, Mark Rutland wrote:
> > On Tue, Jun 27, 2017 at 04:07:58PM -0500, Kim Phillips wrote:
> > > FWIW, there is also this one I saw with mmap-pages set to 5
> > > (pages), which gets rounded up to 8 pages:
> > 
> > Sorry, *what* does the rounding upwards? Userspace, perf core, or the
> > driver? Where?

SPE implementations may vary from the minimum buffer alignment of the
smallest available page size, so I left the bts userspace tool code's
upwards-rounding code intact for now.  

I'll take this opportunity to submit the SPE perf tool patch in the
form of a reply to this email:  Look for the rounding code in
tools/perf/arch/arm64/util/arm-spe.c:arm_spe_recording_options().

> > That's worrying. I'll see if I can reproduce this.
> 
> Actually, this might be down to the IDX2OFF() macro being borked for non
> power-of-two buffer sizes.
> 
> Do you have Will's latest fixes? In his tree there's a commit:
> 
>   4f331cd62531dce2 ("squash! drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension")
> 
> ... which should fix the IDX2OFF() bug.

yes, I've been running with that squash! commit since a couple of days
after I noticed it over a week ago.

> It's be good to reproduce the issue if we can, regardless.

FWIW, I couldn't the little I tried today.

Kim