From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH] perf tools: set no branch type for dummy event in PT
Date: Thu, 29 Jun 2017 17:39:32 +0200 [thread overview]
Message-ID: <20170629153932.GA2924@krava> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775371415B@SHSMSX103.ccr.corp.intel.com>
On Thu, Jun 29, 2017 at 03:31:45PM +0000, Liang, Kan wrote:
SNIP
> > > static int intel_pt_recording_options(struct auxtrace_record *itr,
> > > struct perf_evlist *evlist,
> > > struct record_opts *opts)
> > > @@ -701,6 +717,8 @@ static int intel_pt_recording_options(struct
> > auxtrace_record *itr,
> > > perf_evsel__set_sample_bit(switch_evsel,
> > TIME);
> > > perf_evsel__set_sample_bit(switch_evsel,
> > CPU);
> > >
> > > + add_no_lbr_config_term(&switch_evsel-
> > >config_terms);
> > > +
> >
> > hum, why can't you change the sample bit directly? with:
> >
> > perf_evsel__reset_sample_bit(switch_evsel,
> > BRANCH_STACK);
>
> It will be overwrite in perf_evsel__config.
>
where? you set the evsel->no_aux_samples
jirka
next prev parent reply other threads:[~2017-06-29 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 14:31 [PATCH] perf tools: set no branch type for dummy event in PT kan.liang
2017-06-29 15:29 ` Jiri Olsa
2017-06-29 15:31 ` Liang, Kan
2017-06-29 15:39 ` Jiri Olsa [this message]
2017-06-29 15:50 ` Liang, Kan
2017-06-30 7:06 ` Jiri Olsa
2017-06-30 14:01 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629153932.GA2924@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox