From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Larry Woodman <lwoodman@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/1] expand_downwards: don't require the gap if !vm_prev
Date: Thu, 29 Jun 2017 20:55:28 +0200 [thread overview]
Message-ID: <20170629185528.GA1394@redhat.com> (raw)
In-Reply-To: <CA+55aFyqR0gzfvGx027U4-ZyAYeFbf=cSu6n9bwc0kCTpY+HkA@mail.gmail.com>
On 06/29, Linus Torvalds wrote:
>
> On Thu, Jun 29, 2017 at 8:19 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Hmm. May be you misread this patch?
>
> Ahh, yes. I'm ok with your patch.
>
> That said, you did remove something extra: the comment about
>
> /* Check that both stack segments have the same anon_vma? */
I didn't ;) I moved it up, right above VM_GROWSDOWN check.
> is actually still relevant wrt that VM_GROWSDOWN test. The issue is
> that we could actually limit the VM_GROWSDOWN thing to only be ok with
> merging with a previous vma only if it *really* was the same segment.
Yes, yes, this is clear. This comment motivated me to ask that question,
I thought that we probably do not need to reconcile the stacks even in
this case.
Oleg.
next prev parent reply other threads:[~2017-06-29 18:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 17:52 [PATCH 0/1] expand_downwards: don't require the gap if !vm_prev Oleg Nesterov
2017-06-28 17:52 ` [PATCH 1/1] " Oleg Nesterov
2017-06-30 13:16 ` Michal Hocko
2017-06-28 23:26 ` [PATCH 0/1] " Linus Torvalds
2017-06-29 15:19 ` Oleg Nesterov
2017-06-29 18:21 ` Linus Torvalds
2017-06-29 18:55 ` Oleg Nesterov [this message]
2017-06-29 19:00 ` Linus Torvalds
2017-06-30 13:24 ` Michal Hocko
2017-06-30 17:08 ` Linus Torvalds
2017-06-30 17:26 ` Michal Hocko
2017-06-30 17:48 ` Linus Torvalds
2017-07-03 15:49 ` Michal Hocko
2017-07-03 16:30 ` Linus Torvalds
2017-07-03 16:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629185528.GA1394@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mhocko@suse.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox