From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdF3AZh (ORCPT ); Thu, 29 Jun 2017 20:25:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40398 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbdF3AZg (ORCPT ); Thu, 29 Jun 2017 20:25:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A322E60AD7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 29 Jun 2017 17:25:34 -0700 From: Stephen Boyd To: Jerome Brunet Cc: Sudeep Holla , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Kevin Hilman Subject: Re: [PATCH] clk: scpi: error when clock fails to register Message-ID: <20170630002534.GF22780@codeaurora.org> References: <20170628135345.9337-1-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628135345.9337-1-jbrunet@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28, Jerome Brunet wrote: > Current implementation of scpi_clk_add just print a warning when clock > fails to register but then keep going as if nothing happened. The > provider is then registered with bogus data. > > This may latter lead to an Oops in __clk_create_clk when > hlist_add_head(&clk->clks_node, &hw->core->clks) is called. > > This patch fixes the issue and errors if a clock fails to register. > > Fixes: cd52c2a4b5c4 ("clk: add support for clocks provided by SCP(System Control Processor)") > Signed-off-by: Jerome Brunet > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project