From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure
Date: Fri, 30 Jun 2017 02:34:03 -0500 [thread overview]
Message-ID: <20170630073403.GA24756@embeddedgus> (raw)
Print error message on platform_get_irq failure before return.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/dma/idma64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index 1953e57..08ade66 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -637,8 +637,10 @@ static int idma64_platform_probe(struct platform_device *pdev)
return -ENOMEM;
chip->irq = platform_get_irq(pdev, 0);
- if (chip->irq < 0)
+ if (chip->irq < 0) {
+ dev_err(dev, "failed to get IRQ: %d\n", chip->irq);
return chip->irq;
+ }
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
chip->regs = devm_ioremap_resource(dev, mem);
--
2.5.0
next reply other threads:[~2017-06-30 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 7:34 Gustavo A. R. Silva [this message]
2017-06-30 8:09 ` [PATCH] dmaengine: idma64: print error message on platform_get_irq failure Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630073403.GA24756@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox