From: kan.liang@intel.com
To: acme@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, adrian.hunter@intel.com,
alexander.shishkin@linux.intel.com, ak@linux.intel.com,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH V2 2/2] perf tools: always set no branch for dummy event in PT
Date: Fri, 30 Jun 2017 10:16:56 -0400 [thread overview]
Message-ID: <20170630141656.1626-2-kan.liang@intel.com> (raw)
In-Reply-To: <20170630141656.1626-1-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
An earlier kernel patch allowed enabling PT and LBR at the same time on
Goldmont.
commit ccbebba4c6bf ("perf/x86/intel/pt: Bypass PT vs. LBR exclusivity
if the core supports it")
However, users still cannot use Intel PT and LBRs simultaneously.
$ sudo perf record -e cycles,intel_pt//u -b -- sleep 1
Error:
PMU Hardware doesn't support sampling/overflow-interrupts.
PT implicitly adds dummy event in perf tool. dummy event is software
event which doesn't support LBR.
Always setting no branch for dummy event in Intel PT.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
Changes since V1
- change the BRANCH_STACK sample bit directly (jirka)
tools/perf/arch/x86/util/intel-pt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index 4fe1aed..2201f3b 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -700,6 +700,7 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,
perf_evsel__set_sample_bit(switch_evsel, TID);
perf_evsel__set_sample_bit(switch_evsel, TIME);
perf_evsel__set_sample_bit(switch_evsel, CPU);
+ perf_evsel__reset_sample_bit(switch_evsel, BRANCH_STACK);
opts->record_switch_events = false;
ptr->have_sched_switch = 3;
@@ -761,6 +762,7 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,
/* And the CPU for switch events */
perf_evsel__set_sample_bit(tracking_evsel, CPU);
}
+ perf_evsel__reset_sample_bit(tracking_evsel, BRANCH_STACK);
}
/*
--
2.9.4
next prev parent reply other threads:[~2017-06-30 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 14:16 [PATCH V2 1/2] perf tools: set no_aux_samples for the tracking event in PT kan.liang
2017-06-30 14:16 ` kan.liang [this message]
2017-07-03 7:58 ` [PATCH V2 2/2] perf tools: always set no branch for dummy " Jiri Olsa
2017-07-03 16:59 ` Arnaldo Carvalho de Melo
2017-07-19 14:28 ` Liang, Kan
2017-07-19 14:35 ` Arnaldo Carvalho de Melo
2017-07-26 17:13 ` [tip:perf/core] perf intel-pt: Always set no branch for dummy event tip-bot for Kan Liang
2017-07-26 17:13 ` [tip:perf/core] perf intel-pt: Set no_aux_samples for the tracking event tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630141656.1626-2-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox