Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

Hans de Goede
2017-06-30T15:42:45Z

HI,

On 30-06-17 17:24, Benjamin Tissoires wrote:
> On Jun 29 2017 or thereabouts, Rafael J. Wysocki wrote:
>> On Thu, Jun 29, 2017 at 4:22 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>> +Cc: Hans (he might give some advice regarding to the below)
>>>
>>> On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires
>>> <benjamin.tissoires@redhat.com> wrote:
>>>> MSHW0011 replaces the battery firmware by using ACPI operation regions.
>>>> The values have been obtained by reverse engineering, and are subject to
>>>> errors. Looks like it works on overall pretty well.
>>>
>>> What devices (laptops, tablets) have it?
>>> Surface 3. What else?
>>>
>>>> I couldn't manage to get the IRQ correctly triggered, so I am using a
>>>> good old polling thread to check for changes.
>>>
>>> It might be
>>>
>>>>
>>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=106231
>>>
>>>> +config ACPI_SURFACE3_POWER_OPREGION
>>>> + tristate "Surface 3 battery platform operation region support"
>>>
>>> depends on ACPI ?
>>>
>>>> + help
>>>> + Select this option to enable support for ACPI operation
>>>> + region of the Surface 3 battery platform driver.
>>>
>>>> +/*
>>>> + * Supports for the power IC on the Surface 3 tablet.
>>>
>>> Shouldn't it go to drivers/acpi/pmic folder ?
>>
>> Surely not directly into drivers/acpi/ in any case.
>>
>
> Yep, drivers/acpi/pmic seems like a good candidate. I will do that in
> v3.

Sorry to add to the bikeshedding here, but IMHO drivers/acpi/pmic
is not a good location, that is for PMIC OpRegion drivers, and the
chips you're writing an OpRegion handler for are not PMICs they
are a charger and a fuel-gauge chip. As such I believe a better
location would be the catch all drivers/platform/x86 .

Anyways just my 2 cents if everyone else is happy with putting this
in drivers/acpi/pmic that is fine with me.

Regards,

Hans