From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbdGASBd (ORCPT ); Sat, 1 Jul 2017 14:01:33 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33453 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752AbdGASBb (ORCPT ); Sat, 1 Jul 2017 14:01:31 -0400 Date: Sat, 1 Jul 2017 11:01:29 -0700 From: Kees Cook To: Ingo Molnar Cc: Peter Zijlstra , Josh Poimboeuf , Elena Reshetova , linux-kernel@vger.kernel.org Subject: [PATCH] locking/refcounts: Remove refcount_sub() extern Message-ID: <20170701180129.GA17405@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_REFCOUNT_FULL (correctly) did not provide a refcount_sub(), which should not be part of proper refcount design patterns. This removes the erroneous extern (and the later non-FULL accidental implementation). Fixes: 29dee3c03abc ("locking/refcounts: Out-of-line everything") Signed-off-by: Kees Cook --- This should be applied to locking/core for -next, please. --- include/linux/refcount.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/linux/refcount.h b/include/linux/refcount.h index 099c32bd07b2..c31579bcf1fe 100644 --- a/include/linux/refcount.h +++ b/include/linux/refcount.h @@ -49,7 +49,6 @@ extern __must_check bool refcount_inc_not_zero(refcount_t *r); extern void refcount_inc(refcount_t *r); extern __must_check bool refcount_sub_and_test(unsigned int i, refcount_t *r); -extern void refcount_sub(unsigned int i, refcount_t *r); extern __must_check bool refcount_dec_and_test(refcount_t *r); extern void refcount_dec(refcount_t *r); @@ -81,11 +80,6 @@ static inline __must_check bool refcount_sub_and_test(unsigned int i, return atomic_sub_and_test(i, &r->refs); } -static inline void refcount_sub(unsigned int i, refcount_t *r) -{ - atomic_sub(i, &r->refs); -} - static inline __must_check bool refcount_dec_and_test(refcount_t *r) { return atomic_dec_and_test(&r->refs); -- 2.7.4 -- Kees Cook Pixel Security